From 872a90e039f8db446a43006671b676cd7d3065cb Mon Sep 17 00:00:00 2001
From: Benjamin Arias <benjamin.j.arias@gmail.com>
Date: Fri, 25 Nov 2022 18:03:40 +0100
Subject: [PATCH] fix: Utilise <a>

---
 site/source/App.tsx                      | 8 ++------
 site/source/components/layout/Header.tsx | 7 ++-----
 site/source/hooks/useGetFullPath.ts      | 2 +-
 site/source/pages/Landing/Landing.tsx    | 7 ++-----
 4 files changed, 7 insertions(+), 17 deletions(-)

diff --git a/site/source/App.tsx b/site/source/App.tsx
index 0d25782d1..85da9a403 100644
--- a/site/source/App.tsx
+++ b/site/source/App.tsx
@@ -20,9 +20,7 @@ import { useIsEmbedded } from '@/components/utils/useIsEmbedded'
 import { Container, Spacing } from '@/design-system/layout'
 
 import Provider, { ProviderProps } from './Provider'
-import { Link } from './design-system/typography/link'
 import { useAxeCoreAnalysis } from './hooks/useAxeCoreAnalysis'
-import { useGetFullPath } from './hooks/useGetFullPath'
 import { useSaveAndRestoreScrollPosition } from './hooks/useSaveAndRestoreScrollPosition'
 import Accessibilité from './pages/Accessibilité'
 import Budget from './pages/Budget/Budget'
@@ -99,8 +97,6 @@ const App = () => {
 
 	const { t } = useTranslation()
 
-	const fullPath = useGetFullPath()
-
 	useSaveAndRestoreScrollPosition()
 	const isEmbedded = useIsEmbedded()
 	if (!import.meta.env.PROD && import.meta.env.VITE_AXE_CORE_ENABLED) {
@@ -113,9 +109,9 @@ const App = () => {
 	return (
 		<StyledLayout isEmbedded={isEmbedded}>
 			{!isEmbedded && <Header />}
-			<Link href={`${fullPath}#footer`} className="skip-link print-hidden">
+			<a href="#footer" className="skip-link print-hidden">
 				{t('Passer le contenu')}
-			</Link>
+			</a>
 			<main role="main" id="main">
 				<Container>
 					<ErrorBoundary fallback={CatchOffline}>
diff --git a/site/source/components/layout/Header.tsx b/site/source/components/layout/Header.tsx
index acb4971fe..bcc3ba4df 100644
--- a/site/source/components/layout/Header.tsx
+++ b/site/source/components/layout/Header.tsx
@@ -9,7 +9,6 @@ import { Container } from '@/design-system/layout'
 import { Switch } from '@/design-system/switch'
 import { Link } from '@/design-system/typography/link'
 import { useDarkMode } from '@/hooks/useDarkMode'
-import { useGetFullPath } from '@/hooks/useGetFullPath'
 import { useSitePaths } from '@/sitePaths'
 
 import NewsBanner from './NewsBanner'
@@ -17,8 +16,6 @@ import NewsBanner from './NewsBanner'
 export default function Header() {
 	const { absoluteSitePaths } = useSitePaths()
 
-	const fullPath = useGetFullPath()
-
 	const {
 		i18n: { language },
 		t,
@@ -28,9 +25,9 @@ export default function Header() {
 
 	return (
 		<header role="banner">
-			<Link href={`${fullPath}#main`} className="skip-link">
+			<a href="#main" className="skip-link print-hidden">
 				{t('Aller au contenu')}
-			</Link>
+			</a>
 			<Container>
 				<StyledHeader role="banner">
 					<Link
diff --git a/site/source/hooks/useGetFullPath.ts b/site/source/hooks/useGetFullPath.ts
index e97eaf527..7cd510743 100644
--- a/site/source/hooks/useGetFullPath.ts
+++ b/site/source/hooks/useGetFullPath.ts
@@ -14,7 +14,7 @@ export const useGetFullPath = () => {
 
 	const language = i18n.language as 'fr' | 'en'
 
-	const pathStart = isDevelopment() ? DEVELOPMENT_BASE_PATHS[language] : '/'
+	const pathStart = isDevelopment() ? DEVELOPMENT_BASE_PATHS[language] : ''
 
 	return `${pathStart}${pathname !== '/' ? pathname : ''}`
 }
diff --git a/site/source/pages/Landing/Landing.tsx b/site/source/pages/Landing/Landing.tsx
index f06adb2c0..c854a8aa4 100644
--- a/site/source/pages/Landing/Landing.tsx
+++ b/site/source/pages/Landing/Landing.tsx
@@ -10,7 +10,6 @@ import { Container, Grid, Spacing } from '@/design-system/layout'
 import { H2 } from '@/design-system/typography/heading'
 import { Link } from '@/design-system/typography/link'
 import { Body, Intro } from '@/design-system/typography/paragraphs'
-import { useGetFullPath } from '@/hooks/useGetFullPath'
 import { useSitePaths } from '@/sitePaths'
 
 import { TrackPage } from '../../ATInternetTracking'
@@ -25,8 +24,6 @@ export default function Landing() {
 	const { absoluteSitePaths } = useSitePaths()
 	const { t } = useTranslation()
 
-	const fullPath = useGetFullPath()
-
 	return (
 		<>
 			<TrackPage chapter1="informations" name="accueil" />
@@ -37,9 +34,9 @@ export default function Landing() {
 				ogImage="/logo-share.png"
 			/>
 			<Header />
-			<Link href={`${fullPath}#footer`} className="skip-link print-hidden">
+			<a href="#footer" className="skip-link print-hidden">
 				{t('Passer le contenu')}
-			</Link>
+			</a>
 			<main role="main" id="main">
 				<Container>
 					<PageHeader