🐛 Désactive les cookies pour les iframes sur Safari Mobile

Relatif à #893.
pull/917/head
Maxime Quandalle 2020-03-08 19:43:21 +01:00
parent fc07701079
commit 7df6e5d318
No known key found for this signature in database
GPG Key ID: 428641C03D29CA10
1 changed files with 10 additions and 11 deletions

View File

@ -7,7 +7,9 @@ declare global {
}
}
type PushArgs = ['trackPageView'] | ['trackEvent', ...Array<string | number>]
type TrackingAction = 'trackPageView' | 'trackEvent' | 'disableCookies'
type PushArgs = [TrackingAction, ...Array<string | number>]
type PushType = (args: PushArgs) => void
const ua = window.navigator.userAgent
@ -22,18 +24,15 @@ export default class Tracker {
previousPath: string | undefined
constructor(
pushFunction: PushType = args => {
// There is an issue with the way Safari handle cookies in iframe, cf.
// https://gist.github.com/iansltx/18caf551baaa60b79206. We could probably
// do better but for now we don't track action of iOs Safari user in
// iFrame -- to avoid errors in the number of visitors in our stats.
if (!(iOSSafari && inIframe)) {
window._paq.push(args)
}
}
pushFunction: PushType = args => (window?._paq ?? []).push(args)
) {
if (typeof window !== 'undefined') window._paq = window._paq || []
this.push = debounce(200, pushFunction) as PushType
// There is an issue with the way Safari handle cookies in iframe, cf.
// https://gist.github.com/iansltx/18caf551baaa60b79206.
// TODO : We don't need to disable cookies if a cookie is already set
if (iOSSafari && inIframe) {
pushFunction(['disableCookies'])
}
}
connectToHistory(history: History) {