betagouv
/
mon-entreprise
mirror of https://github.com/betagouv/mon-entreprise
1
0
Fork 0
Code Releases Activity

✅ Tester les variables manquantes dans les variations

pull/25/head
Laurent Bossavit 2017-07-28 15:33:35 +02:00
parent ee91d15e07
commit 7ccc8e4e1f
2 changed files with 44 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/engine/mecanisms.js
View File

@ -97,8 +97,10 @@ let devariate = (recurse, k, v) => {
nodeValue = choice ? choice.nodeValue : null
let collectMissing = node => {
let choice = R.find(node => node.condition.nodeValue, node.explanation)
return choice ? collectNodeMissing(choice) : R.chain(collectNodeMissing,node.explanation)
let choice = R.find(node => node.condition.nodeValue, node.explanation),
leftMissing = choice ? [] : R.chain(collectNodeMissing,R.pluck("condition",node.explanation)),
rightMissing = choice ? collectNodeMissing(choice) : R.chain(collectNodeMissing,node.explanation)
return R.concat(leftMissing,rightMissing)
}
return rewriteNode(node,nodeValue,explanation,collectMissing)

40
test/generateQuestions.test.js
View File

@ -86,6 +86,46 @@ describe('collectMissingVariables', function() {
expect(result).to.have.property('top . dix')
});
it('should report missing variables in variations', function() {
let rawRules = [
{nom: "startHere", formule: {somme: ["variations"]}, espace: "top"},
{nom: "variations", espace: "top", formule: {"barème": {
assiette:2008,
"multiplicateur des tranches":1000,
"variations":[
{si: "dix", "tranches":[{"en-dessous de":1, taux: 0.1},{de:1, "à": 2, taux: "deux"}, ,{"au-dessus de":2, taux: 10}]},
{si: "3 > 4", "tranches":[{"en-dessous de":1, taux: 0.1},{de:1, "à": 2, taux: 1.8}, ,{"au-dessus de":2, taux: 10}]},
]
}}},
{nom: "dix", espace: "top"},
{nom: "deux", espace: "top"}],
rules = rawRules.map(enrichRule),
situation = analyseTopDown(rules,"startHere")(stateSelector),
result = collectMissingVariables()(stateSelector,situation)
expect(result).to.have.property('top . dix')
// expect(result).to.have.property('top . deux') - this is a TODO
});
it('should not report missing variables in irrelevant variations', function() {
let rawRules = [
{nom: "startHere", formule: {somme: ["variations"]}, espace: "top"},
{nom: "variations", espace: "top", formule: {"barème": {
assiette:2008,
"multiplicateur des tranches":1000,
"variations":[
{si: "dix", "tranches":[{"en-dessous de":1, taux: 0.1},{de:1, "à": 2, taux: "deux"}, ,{"au-dessus de":2, taux: 10}]},
{si: "3 > 2", "tranches":[{"en-dessous de":1, taux: 0.1},{de:1, "à": 2, taux: 1.8}, ,{"au-dessus de":2, taux: 10}]},
]
}}},
{nom: "dix", espace: "top"}],
rules = rawRules.map(enrichRule),
situation = analyseTopDown(rules,"startHere")(stateSelector),
result = collectMissingVariables()(stateSelector,situation)
expect(result).to.deep.equal({})
});
it('should not report missing variables in switch for consequences of false conditions', function() {
let rawRules = [
{ nom: "startHere", formule: {"aiguillage numérique": {